hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sohan Jain" <sohanj...@fb.com>
Subject Re: Review Request: HIVE-2188: Add a function to retrieve multiple tables on trip to the hive metastore
Date Tue, 07 Jun 2011 01:11:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/831/
-----------------------------------------------------------

(Updated 2011-06-07 01:11:44.582629)


Review request for hive, Paul Yang and Ashutosh Chauhan.


Changes
-------

- included Carl's suggestions.
- get_table_objects_by_name retrieves only the tables that it can, and does not fail out if
it cannot retrieve a table.  
- removed the ordering of tables returned, since there is no guarantee every requested table
is returned
- modified unit tests


Summary
-------

Created a function "multi_get_table" that retrieves multiple tables on one trip to the hive
metastore, saving round trip time.


This addresses bug HIVE-2188.
    https://issues.apache.org/jira/browse/HIVE-2188


Diffs (updated)
-----

  trunk/metastore/if/hive_metastore.thrift 1130342 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1130342 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1130342 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1130342 
  trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1130342


Diff: https://reviews.apache.org/r/831/diff


Testing
-------

Added a test case to testMetasore() in TestHiveServer.  Also tested for speed improvements
in a client session.


Thanks,

Sohan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message