hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: HIVE-2194: Add actions to MetaStoreEventListener to be performed on alter table and alter partition operations.
Date Fri, 03 Jun 2011 20:55:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/853/#review758
-----------------------------------------------------------



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
<https://reviews.apache.org/r/853/#comment1598>

    This method should either succeed or throw an exception. Since it already throws checked
exceptions, adding a boolean return value makes things more complicated for the caller, and
signals the same type of failure as an exception but without the ability to include information
about what caused the failure. I think it would be better to modify the code so that an exception
is always thrown when success==FALSE.
    
    This comment also applies to the various alterTable and alterPartition methods located
in other classes.


- Carl


On 2011-06-03 20:20:03, Sohan Jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/853/
> -----------------------------------------------------------
> 
> (Updated 2011-06-03 20:20:03)
> 
> 
> Review request for hive and Paul Yang.
> 
> 
> Summary
> -------
> 
> HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to
be performed after particular events on a metastore. Improve upon that class by adding events
to be performed on "alter table" and "alter partition" actions.  Also, update the hive metastore
to call the appropriate functions of the listeners when the events happen.
> 
> 
> This addresses bug HIVE-2194.
>     https://issues.apache.org/jira/browse/HIVE-2194
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java 1130342

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1130342

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1130342

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
1130342 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1130342

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1130342 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java
PRE-CREATION 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java
PRE-CREATION 
>   trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1130342

>   trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
1130342 
> 
> Diff: https://reviews.apache.org/r/853/diff
> 
> 
> Testing
> -------
> 
> Added test cases to TestMetaStoreEventListener.
> 
> 
> Thanks,
> 
> Sohan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message