hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-872) Allow BIGINT constants
Date Tue, 14 Jun 2011 19:06:48 GMT

    [ https://issues.apache.org/jira/browse/HIVE-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049343#comment-13049343
] 

jiraposter@reviews.apache.org commented on HIVE-872:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/889/
-----------------------------------------------------------

(Updated 2011-06-14 19:04:53.630834)


Review request for hive and John Sichi.


Changes
-------

After talking to jhsu about this, looks like the motivation for this is to provide a way to
coerce int literals into bigints for UDFs that expect arguments of the same type. E.g. COALESCE(0,
1152921504606846976) will currently fail. With this updated patch, COALESCE(0L, 1152921504606846976)
passes.


Summary
-------

Added a rule to the lexical grammar to allow BIGINT constants ending with 'L', and a clause
to the TypeCheckProcFactory to ensure it gets interpreted properly.


This addresses bug HIVE-872.
    https://issues.apache.org/jira/browse/HIVE-872


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 9161319 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java dfadb9f 
  ql/src/test/queries/clientpositive/bigint_const.q PRE-CREATION 
  ql/src/test/results/clientpositive/bigint_const.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/889/diff


Testing
-------

TestCliDriver passes, previous behaviour was to accept bigint constants specified without
'L', which is also preserved, so adding additional tests for this case seems unnecessary.


Thanks,

Syed



> Allow BIGINT constants
> ----------------------
>
>                 Key: HIVE-872
>                 URL: https://issues.apache.org/jira/browse/HIVE-872
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Zheng Shao
>            Assignee: Syed S. Albiz
>         Attachments: HIVE-872.1.patch
>
>
> We should allow "0L" to be interpreted as a bigint constant.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message