hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI
Date Tue, 17 May 2011 18:59:47 GMT

    [ https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034973#comment-13034973
] 

jiraposter@reviews.apache.org commented on HIVE-243:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/
-----------------------------------------------------------

(Updated 2011-05-17 18:56:20.310048)


Review request for hive.


Changes
-------

updating diff against the latest trunk


Summary
-------

Fixed by adding INT signal hander that interrupts the CLI thread. The CLI thread gets InterruptedException
and it stops the current command.


This addresses bug HIVE-243.
    https://issues.apache.org/jira/browse/HIVE-243


Diffs (updated)
-----

  trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1104456 
  trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java PRE-CREATION

  trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java PRE-CREATION

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1104456 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1104456 

Diff: https://reviews.apache.org/r/626/diff


Testing
-------

Manual test Ctrl+C on bunch of command (show tables, select, etc)
Tested interrupting the command on large data set in different stages of the processing (JDO,
MapReduce, building the input summary).
example queries:
explain select count(*) from xyz where ds = '2011-02-01';
select count(*) from xyz where ds = '2011-02-01';


Thanks,

georgedj



> ^C breaks out of running query, but not whole CLI
> -------------------------------------------------
>
>                 Key: HIVE-243
>                 URL: https://issues.apache.org/jira/browse/HIVE-243
>             Project: Hive
>          Issue Type: Wish
>          Components: Query Processor
>    Affects Versions: 0.8.0
>            Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. I can do
that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was some control
character to break out of a query without breaking out of the CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message