hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chinna Rao Lalam (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HIVE-2183) In Task class and its subclasses logger is initialized in constructor
Date Wed, 25 May 2011 06:29:47 GMT
In Task class and its subclasses logger is initialized in constructor
---------------------------------------------------------------------

                 Key: HIVE-2183
                 URL: https://issues.apache.org/jira/browse/HIVE-2183
             Project: Hive
          Issue Type: Bug
          Components: Query Processor
    Affects Versions: 0.5.0, 0.8.0
         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586)
- Kernel 2.6.16.60-0.21-smp (5)
            Reporter: Chinna Rao Lalam
            Assignee: Chinna Rao Lalam
            Priority: Minor


In Task class and its subclasses logger is initialized in constructor. Log object no need
to initialize every time in the constructor, Log object can make it as static object.

{noformat}
Ex:
  public ExecDriver() {
    super();
    LOG = LogFactory.getLog(this.getClass().getName());
    console = new LogHelper(LOG);
    this.jobExecHelper = new HadoopJobExecHelper(job, console, this, this);
  }
{noformat}

Need to change like this

{noformat}
private static final Log LOG = LogFactory.getLog(ExecDriver.class);
{noformat}



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message