hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sichi" <jsi...@fb.com>
Subject Re: Review Request: HIVE-2156: Improve Execution Error Messages
Date Mon, 23 May 2011 20:03:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/777/#review707
-----------------------------------------------------------



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/777/#comment1411>

    Isn't this an unrelated change?  It seems like a good thing to do, just not part of this
JIRA issue.
    



ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
<https://reviews.apache.org/r/777/#comment1412>

    Someone may have changed the log4j configuration, so this isn't good enough.  There's
a way to get the file path corresponding to a log4j FileAppender (method getFile()), so maybe
you can use that?
    



ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
<https://reviews.apache.org/r/777/#comment1413>

    The timeout should be configurable.



ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java
<https://reviews.apache.org/r/777/#comment1414>

    Add Javadoc.



ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java
<https://reviews.apache.org/r/777/#comment1415>

    Any fallback we should try if IOException occurs?


- John


On 2011-05-23 18:25:37, Syed Albiz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/777/
> -----------------------------------------------------------
> 
> (Updated 2011-05-23 18:25:37)
> 
> 
> Review request for hive and John Sichi.
> 
> 
> Summary
> -------
> 
> - Add local error messages to point to job logs and provide TaskIDs
> - Add a timeout to the fetching of task logs and errors
> 
> 
> This addresses bug HIVE-2156.
>     https://issues.apache.org/jira/browse/HIVE-2156
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dc96a1f 
>   conf/hive-default.xml 159d825 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 4717c25 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java 53769a0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MapredLocalTask.java 691f038 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 9cb407c 
>   ql/src/test/results/clientnegative/dyn_part3.q.out 5f4df65 
>   ql/src/test/results/clientnegative/script_broken_pipe1.q.out d33d2cc 
>   ql/src/test/results/clientnegative/script_broken_pipe2.q.out afbaa44 
>   ql/src/test/results/clientnegative/script_broken_pipe3.q.out fe8f757 
>   ql/src/test/results/clientnegative/script_error.q.out c72d780 
>   ql/src/test/results/clientnegative/udf_reflect_neg.q.out f2082a3 
>   ql/src/test/results/clientnegative/udf_test_error.q.out 5fd9a00 
>   ql/src/test/results/clientnegative/udf_test_error_reduce.q.out ddc5e5b 
> 
> Diff: https://reviews.apache.org/r/777/diff
> 
> 
> Testing
> -------
> 
> Tested TestNegativeCliDriver in both local and miniMR mode
> 
> 
> Thanks,
> 
> Syed
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message