hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: HIVE-1095 Hive in maven
Date Mon, 16 May 2011 22:04:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/740/#review668
-----------------------------------------------------------



trunk/LICENSE-2.0.txt
<https://reviews.apache.org/r/740/#comment1329>

    There's already a "LICENSE" file in the rootdir. This file should be removed.



trunk/ant/ivy.xml
<https://reviews.apache.org/r/740/#comment1355>

    Module name should be "hive-anttasks"



trunk/build.xml
<https://reviews.apache.org/r/740/#comment1353>

    We should resolve this dependency using Ivy.



trunk/build.xml
<https://reviews.apache.org/r/740/#comment1330>

    TAB



trunk/build.xml
<https://reviews.apache.org/r/740/#comment1354>

    This should probably go build-common.xml instead of here.



trunk/cli/ivy.xml
<https://reviews.apache.org/r/740/#comment1356>

    Module name should be "hive-cli". Same deal for all of the other */ivy.xml files.


- Carl


On 2011-05-13 06:33:44, Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/740/
> -----------------------------------------------------------
> 
> (Updated 2011-05-13 06:33:44)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Summary
> -------
> 
> 
> This addresses bug HIVE-1095.
>     https://issues.apache.org/jira/browse/HIVE-1095
> 
> 
> Diffs
> -----
> 
>   trunk/LICENSE-2.0.txt PRE-CREATION 
>   trunk/ant/ivy.xml 1095392 
>   trunk/build-common.xml 1095392 
>   trunk/build.xml 1095392 
>   trunk/cli/ivy.xml 1095392 
>   trunk/common/ivy.xml 1095392 
>   trunk/contrib/ivy.xml 1095392 
>   trunk/hbase-handler/ivy.xml 1095392 
>   trunk/hwi/ivy.xml 1095392 
>   trunk/ivy.xml 1095392 
>   trunk/jdbc/ivy.xml PRE-CREATION 
>   trunk/metastore/ivy.xml 1095392 
>   trunk/ql/ivy.xml 1095392 
>   trunk/serde/ivy.xml 1095392 
>   trunk/service/ivy.xml PRE-CREATION 
>   trunk/shims/ivy.xml 1095392 
> 
> Diff: https://reviews.apache.org/r/740/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Amareshwari
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message