hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From djaba...@fb.com
Subject Re: Review Request: HIVE-243 - ^C breaks out of running query, but not whole CLI.
Date Tue, 10 May 2011 21:25:20 GMT


> On 2011-04-20 17:51:59, Ning Zhang wrote:
> > trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java, line 313
> > <https://reviews.apache.org/r/626/diff/1/?file=16075#file16075line313>
> >
> >     Does this handle the case when a MapReduce job is launched and CLI got a CTL+C?
Currently we have a JVM shutdownHook defined in HadoopJobExecHelper.java to kill the MR job
before the JVM shut down (the old behavior when hitting a CTL+C). 
> >     
> >     Here if we don't shut down the JVM, you should do the same thing to kill the
running MR jobs.

Sorry for the delayed response, I didn't get email notification for the comment. Let me try
to hookup the running jobs kill to the ctrl+c handler. I don't think it will do it with the
current code as it will prevent the shutdown hook of being called.


- georgedj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/#review505
-----------------------------------------------------------


On 2011-05-10 21:25:03, georgedj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/626/
> -----------------------------------------------------------
> 
> (Updated 2011-05-10 21:25:03)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> Fixed by adding INT signal hander that interrupts the CLI thread. The CLI thread gets
InterruptedException and it stops the current command.
> 
> 
> This addresses bug HIVE-243.
>     https://issues.apache.org/jira/browse/HIVE-243
> 
> 
> Diffs
> -----
> 
>   trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312 
>   trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java PRE-CREATION

>   trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java PRE-CREATION

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1100312

>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1100312 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312 
> 
> Diff: https://reviews.apache.org/r/626/diff
> 
> 
> Testing
> -------
> 
> Manual test Ctrl+C on bunch of command (show tables, select, etc)
> 
> 
> Thanks,
> 
> georgedj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message