hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2171) Allow custom serdes to set field comments
Date Thu, 26 May 2011 20:18:47 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039900#comment-13039900
] 

jiraposter@reviews.apache.org commented on HIVE-2171:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/790/
-----------------------------------------------------------

Review request for hive.


Summary
-------

HIVE-2171: Allow custom serdes to set field comments


This addresses bug HIVE-2171.
    https://issues.apache.org/jira/browse/HIVE-2171


Diffs
-----

  ivy/libraries.properties af856bd 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java c1fa4e5 
  serde/ivy.xml d6c836a 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
4850601 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
e2fa9db 
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryObjectInspectorFactory.java
2947e49 
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryStructObjectInspector.java
3d5408f 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ColumnarStructObjectInspector.java
66f4f8d 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MetadataListStructObjectInspector.java
bd42a0c 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
90561a1 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java
4a934c5 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardStructObjectInspector.java
3b26e45 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StructField.java 62c3017 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionStructObjectInspector.java
76ff736 
  serde/src/test/org/apache/hadoop/hive/serde2/TestSerdeWithFieldComments.java PRE-CREATION

  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java
f139ea5 

Diff: https://reviews.apache.org/r/790/diff


Testing
-------

New unit test and refactor existing unit test.


Thanks,

Jakob



> Allow custom serdes to set field comments
> -----------------------------------------
>
>                 Key: HIVE-2171
>                 URL: https://issues.apache.org/jira/browse/HIVE-2171
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.7.1
>
>         Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment.
 These are set in the metastore utils to {{(from deserializer)}}.  For those serdes that can
provide meaningful comments for a field, they should be propagated to the table description.
 These serde-provided comments could be prepended to "(from deserializer)" if others feel
that's a meaningful distinction.  This change involves updating {{StructField}} to support
a (possibly null) comment field and then propagating this change out to the myriad places
{{StructField}} is thrown around.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message