Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1DE8F1A62 for ; Fri, 22 Apr 2011 04:22:13 +0000 (UTC) Received: (qmail 57043 invoked by uid 500); 22 Apr 2011 04:22:12 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 56936 invoked by uid 500); 22 Apr 2011 04:22:12 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 56920 invoked by uid 99); 22 Apr 2011 04:22:11 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Apr 2011 04:22:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 328BE1C0049; Fri, 22 Apr 2011 04:22:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1474456124964671432==" MIME-Version: 1.0 Subject: Re: Review Request: CommandNeedRetryException needs release locks and some related code cleaning up From: "Siying Dong" To: "Yongqiang He" , "namit jain" Date: Fri, 22 Apr 2011 04:22:16 -0000 Message-ID: <20110422042216.25142.98887@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/646/ Cc: "hive" , "Siying Dong" , "Carl Steinbach" In-Reply-To: <20110422001143.25142.64266@reviews.apache.org> References: <20110422001143.25142.64266@reviews.apache.org> --===============1474456124964671432== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/646/ ----------------------------------------------------------- (Updated 2011-04-22 04:22:16.136899) Review request for hive, Yongqiang He and namit jain. Changes ------- execute() not to throw any exception. Summary ------- now when CommandNeedRetryException is thrown, locks are not released. Not s= ure whether it will cause problem, since the same locks will be acquired wh= en retrying it. It is anyway something we need to fix. Also we can do some = little code cleaning up to make future mistakes less likely. This addresses bug HIVE-2123. https://issues.apache.org/jira/browse/HIVE-2123 Diffs (updated) ----- trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1095838 = trunk/hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java 1095838 = trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1095838 = trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessor.j= ava 1095838 = Diff: https://reviews.apache.org/r/646/diff Testing ------- Thanks, Siying --===============1474456124964671432==--