Return-Path: Delivered-To: apmail-hive-dev-archive@www.apache.org Received: (qmail 77200 invoked from network); 11 Apr 2011 22:36:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 11 Apr 2011 22:36:01 -0000 Received: (qmail 38374 invoked by uid 500); 11 Apr 2011 22:36:00 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 38345 invoked by uid 500); 11 Apr 2011 22:36:00 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 38336 invoked by uid 99); 11 Apr 2011 22:36:00 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2011 22:36:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1F4A21C0049; Mon, 11 Apr 2011 22:36:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5990962900356736534==" MIME-Version: 1.0 Subject: Review Request: HIVE-2107. Log4J initialization info should not be printed out if -S is specified From: "Ning Zhang" To: "Ning Zhang" , "hive" Date: Mon, 11 Apr 2011 22:36:06 -0000 Message-ID: <20110411223606.9024.42953@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/580/ --===============5990962900356736534== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/580/ ----------------------------------------------------------- Review request for hive. Summary ------- SessionState.initHiveLog4j() is called before hive command argument -S is p= arsed, so initHiveLog4j will printed out the init info even though -S is sp= ecified. Diffs ----- trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1091220 = trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 109= 1220 = Diff: https://reviews.apache.org/r/580/diff Testing ------- Thanks, Ning --===============5990962900356736534==--