Return-Path: Delivered-To: apmail-hive-dev-archive@www.apache.org Received: (qmail 73553 invoked from network); 6 Apr 2011 04:04:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 6 Apr 2011 04:04:34 -0000 Received: (qmail 41945 invoked by uid 500); 6 Apr 2011 04:04:33 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 41864 invoked by uid 500); 6 Apr 2011 04:04:32 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Delivered-To: moderator for dev@hive.apache.org Received: (qmail 34785 invoked by uid 99); 6 Apr 2011 03:53:37 -0000 Content-Type: multipart/alternative; boundary="===============8576182248575610396==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-1988 From: "Amareshwari Sriramadasu" To: "Amareshwari Sriramadasu" , "Devaraj Das" , "hive" Date: Wed, 06 Apr 2011 03:53:40 -0000 Message-ID: <20110406035340.28324.10153@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/528/ In-Reply-To: <20110405212434.18496.86930@reviews.apache.org> References: <20110405212434.18496.86930@reviews.apache.org> --===============8576182248575610396== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/528/#review394 ----------------------------------------------------------- Ship it! +1 - Amareshwari On 2011-04-05 21:24:34, Devaraj Das wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/528/ > ----------------------------------------------------------- > = > (Updated 2011-04-05 21:24:34) > = > = > Review request for hive. > = > = > Summary > ------- > = > Fixes to some security issues discussed in HIVE-1988 > = > = > This addresses bug HIVE-1988. > https://issues.apache.org/jira/browse/HIVE-1988 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.= thrift 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen= -cpp/ThriftHiveMetastore.h 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen= -cpp/ThriftHiveMetastore.cpp 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen= -cpp/ThriftHiveMetastore_server.skeleton.cpp 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen= -javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 108= 9155 = > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen= -php/hive_metastore/ThriftHiveMetastore.php 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen= -py/hive_metastore/ThriftHiveMetastore-remote 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen= -py/hive_metastore/ThriftHiveMetastore.py 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen= -rb/thrift_hive_metastore.rb 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apach= e/hadoop/hive/metastore/HiveMetaStore.java 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apach= e/hadoop/hive/metastore/HiveMetaStoreClient.java 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apach= e/hadoop/hive/metastore/IMetaStoreClient.java 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apa= che/hadoop/hive/thrift/DelegationTokenSecretManager.java 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apa= che/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/ap= ache/hadoop/hive/thrift/HadoopThriftAuthBridge.java 1089155 = > http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/ha= doop/hive/thrift/TestHadoop20SAuthBridge.java 1089155 = > = > Diff: https://reviews.apache.org/r/528/diff > = > = > Testing > ------- > = > New unit test added and that passes. All unit tests passed. > = > = > Thanks, > = > Devaraj > = > --===============8576182248575610396==--