Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A3A5D2C7C for ; Thu, 21 Apr 2011 23:52:44 +0000 (UTC) Received: (qmail 4239 invoked by uid 500); 21 Apr 2011 23:52:44 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 4202 invoked by uid 500); 21 Apr 2011 23:52:44 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 4194 invoked by uid 500); 21 Apr 2011 23:52:44 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 4191 invoked by uid 99); 21 Apr 2011 23:52:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Apr 2011 23:52:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Apr 2011 23:52:43 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id D650AADDA5 for ; Thu, 21 Apr 2011 23:52:05 +0000 (UTC) Date: Thu, 21 Apr 2011 23:52:05 +0000 (UTC) From: "jiraposter@reviews.apache.org (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: <1325911782.75375.1303429925874.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <376769521.8855.1299698219727.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HIVE-2038) Metastore listener MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023037#comment-13023037 ] jiraposter@reviews.apache.org commented on HIVE-2038: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/618/#review526 ----------------------------------------------------------- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java I think it should be possible to specify multiple metastore listeners. Can you please make the following changes: * Change the name of the conf property from "hive.metastore.listener" to "hive.metastore.event.listeners" and update the description to indicate that this is a comma separated list of listener classnames. * Change the default value for this property to be an empty string. * Update the code that initializes these listeners. You can cut and paste the code that's used to initialize hive.exec.pre.hooks - Carl On 2011-04-18 18:44:05, Ashutosh Chauhan wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/618/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-04-18 18:44:05) bq. bq. bq. Review request for hive and Carl Steinbach. bq. bq. bq. Summary bq. ------- bq. bq. Addresses Carl's comment for previous patch. bq. Also added a new method finalizePartition in metastore through which metastore client can indicate to metastore that partition can be finalized. bq. bq. bq. This addresses bug HIVE-2038. bq. https://issues.apache.org/jira/browse/HIVE-2038 bq. bq. bq. Diffs bq. ----- bq. bq. trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1094688 bq. trunk/conf/hive-default.xml 1094688 bq. trunk/metastore/if/hive_metastore.thrift 1094688 bq. trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1094688 bq. trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1094688 bq. trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1094688 bq. trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1094688 bq. trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1094688 bq. trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1094688 bq. trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1094688 bq. trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1094688 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1094688 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1094688 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1094688 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java PRE-CREATION bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1094688 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1094688 bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/618/diff bq. bq. bq. Testing bq. ------- bq. bq. bq. Thanks, bq. bq. Ashutosh bq. bq. > Metastore listener > ------------------ > > Key: HIVE-2038 > URL: https://issues.apache.org/jira/browse/HIVE-2038 > Project: Hive > Issue Type: Improvement > Components: Metastore > Reporter: Ashutosh Chauhan > Assignee: Ashutosh Chauhan > Fix For: 0.8.0 > > Attachments: hive-2038.patch, metastore_listener.patch, metastore_listener.patch, metastore_listener.patch > > > Provide to way to observe changes happening on Metastore -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira