Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 61837237E for ; Fri, 29 Apr 2011 19:07:44 +0000 (UTC) Received: (qmail 80487 invoked by uid 500); 29 Apr 2011 19:07:44 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 80450 invoked by uid 500); 29 Apr 2011 19:07:44 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 80442 invoked by uid 500); 29 Apr 2011 19:07:44 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 80439 invoked by uid 99); 29 Apr 2011 19:07:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Apr 2011 19:07:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Apr 2011 19:07:41 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 400CFB9FC8 for ; Fri, 29 Apr 2011 19:07:03 +0000 (UTC) Date: Fri, 29 Apr 2011 19:07:03 +0000 (UTC) From: "Carl Steinbach (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: <1288874768.12438.1304104023258.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1909588454.5194.1303887243315.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HIVE-2135) Refactor HiveMetaStore.java MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HIVE-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027144#comment-13027144 ] Carl Steinbach commented on HIVE-2135: -------------------------------------- Changes look good to me. Nice to see some cleanup work! @John and Paul: Can one of you take a look at this and make sure it doesn't break anything on the FB side? > Refactor HiveMetaStore.java > --------------------------- > > Key: HIVE-2135 > URL: https://issues.apache.org/jira/browse/HIVE-2135 > Project: Hive > Issue Type: Improvement > Components: Metastore > Reporter: Ashutosh Chauhan > Assignee: Ashutosh Chauhan > Fix For: 0.8.0 > > Attachments: refactor.patch > > > HiveMetaStore.java is more then 3000 LOC which contains wide variety of code. It will be good to refactor it so that its easier to maintain. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira