hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-1943) Metastore operations (like drop_partition) could be improved in terms of maintaining consistency of metadata and data
Date Wed, 13 Apr 2011 06:24:06 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019226#comment-13019226
] 

jiraposter@reviews.apache.org commented on HIVE-1943:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/586/#review437
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml
<https://reviews.apache.org/r/586/#comment851>

    Did not understand why this change is required?



http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/586/#comment850>

    change Table metadata to databse metadata? 



http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/586/#comment849>

    change Table metadata to partition metadata?



http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/586/#comment848>

    change Table metadata to partition metadata?



http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
<https://reviews.apache.org/r/586/#comment845>

    Can this be changed to assert statement instead of throwing exception?



http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
<https://reviews.apache.org/r/586/#comment846>

    Can this be changed to assert statement instead of throwing exception?



http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
<https://reviews.apache.org/r/586/#comment847>

    Can we add the test for group writable also?


- Amareshwari


On 2011-04-12 22:12:32, Devaraj Das wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/586/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-04-12 22:12:32)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This is a patch to handle the issue described in HIVE-1943
bq.  
bq.  
bq.  This addresses bug HIVE-1943.
bq.      https://issues.apache.org/jira/browse/HIVE-1943
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
1090038 
bq.    http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1090038 
bq.    http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml 1090038 
bq.    http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1090038 
bq.    http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
1090038 
bq.    http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
1090038 
bq.    http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java
1090038 
bq.    http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
1090038 
bq.    http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java
1090038 
bq.    http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java
1090038 
bq.  
bq.  Diff: https://reviews.apache.org/r/586/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Unit tests added.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Devaraj
bq.  
bq.



> Metastore operations (like drop_partition) could be improved in terms of maintaining
consistency of metadata and data
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-1943
>                 URL: https://issues.apache.org/jira/browse/HIVE-1943
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>
> Currently, metastore operations with associated hdfs operations like drop_partition doesn't
do a rollback if the hdfs operation fails. The metastore first updates the metadata, and then
tries to do hdfs operation. If the hdfs operation fails for any reason, the data on the hdfs
will be orphaned. We should improve the situation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message