hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2123) CommandNeedRetryException needs release locks
Date Fri, 22 Apr 2011 00:15:05 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023049#comment-13023049
] 

jiraposter@reviews.apache.org commented on HIVE-2123:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/646/
-----------------------------------------------------------

Review request for hive, Yongqiang He and namit jain.


Summary
-------

now when CommandNeedRetryException is thrown, locks are not released. Not sure whether it
will cause problem, since the same locks will be acquired when retrying it. It is anyway something
we need to fix. Also we can do some little code cleaning up to make future mistakes less likely.


This addresses bug HIVE-2123.
    https://issues.apache.org/jira/browse/HIVE-2123


Diffs
-----

  trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1095838 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1095838 

Diff: https://reviews.apache.org/r/646/diff


Testing
-------


Thanks,

Siying



> CommandNeedRetryException needs release locks
> ---------------------------------------------
>
>                 Key: HIVE-2123
>                 URL: https://issues.apache.org/jira/browse/HIVE-2123
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Siying Dong
>            Assignee: Siying Dong
>         Attachments: HIVE-2123.1.patch
>
>
> now when CommandNeedRetryException is thrown, locks are not released. Not sure whether
it will cause problem, since the same locks will be acquired when retrying it. It is anyway
something we need to fix. Also we can do some little code cleaning up to make future mistakes
less likely.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message