hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2135) Refactor HiveMetaStore.java
Date Fri, 29 Apr 2011 20:51:03 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027177#comment-13027177
] 

jiraposter@reviews.apache.org commented on HIVE-2135:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/669/#review622
-----------------------------------------------------------



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreCommand.java
<https://reviews.apache.org/r/669/#comment1265>

    The example in this Javadoc needs to be updated to match the new invocation pattern. 
(Also, the original Javadoc was missing <pre> and <code> tags; can you add those
in here so that the HTML will get generated correctly?)
    
    But first...is the new invocation pattern actually better?  It seems like the invocation
has gotten a little more verbose since each call to executeWithRetry now has to pass in two
arguments.  Wouldn't it be better to leave the executeWithRetry method in the HiveMetaStore
class so that it can do any common stuff like setting these as attributes on the command object?
    
    Likewise, I'm not clear on how moving the thread-local access to the command object is
an improvement.  Seems to me it should stay in HiveMetaStore; again, you can pass the right
object in from executeWithRetry.
    


- John


On 2011-04-27 18:24:42, Ashutosh Chauhan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/669/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-04-27 18:24:42)
bq.  
bq.  
bq.  Review request for hive, Carl Steinbach, John Sichi, and Paul Yang.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  See HIVE-2135
bq.  
bq.  
bq.  This addresses bug HIVE-2135.
bq.      https://issues.apache.org/jira/browse/HIVE-2135
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1096976

bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreCommand.java PRE-CREATION

bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1096976

bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/URLConnectionUpdater.java
PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/669/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Since this is a refactoring patch, no new tests are required. Ran all the tests in metastore.
All of them passed.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ashutosh
bq.  
bq.



> Refactor HiveMetaStore.java
> ---------------------------
>
>                 Key: HIVE-2135
>                 URL: https://issues.apache.org/jira/browse/HIVE-2135
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: refactor.patch
>
>
> HiveMetaStore.java is more then 3000 LOC which contains wide variety of code. It will
be good to refactor it so that its easier to maintain.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message