hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI
Date Wed, 20 Apr 2011 17:54:06 GMT

    [ https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022256#comment-13022256
] 

jiraposter@reviews.apache.org commented on HIVE-243:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/#review505
-----------------------------------------------------------



trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/626/#comment1030>

    Does this handle the case when a MapReduce job is launched and CLI got a CTL+C? Currently
we have a JVM shutdownHook defined in HadoopJobExecHelper.java to kill the MR job before the
JVM shut down (the old behavior when hitting a CTL+C). 
    
    Here if we don't shut down the JVM, you should do the same thing to kill the running MR
jobs. 


- Ning


On 2011-04-20 16:49:05, georgedj wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/626/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-04-20 16:49:05)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Fixed by adding INT signal hander that interrupts the CLI thread. The CLI thread gets
InterruptedException and it stops the current command.
bq.  
bq.  
bq.  This addresses bug HIVE-243.
bq.      https://issues.apache.org/jira/browse/HIVE-243
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1095439 
bq.  
bq.  Diff: https://reviews.apache.org/r/626/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Manual test Ctrl+C on bunch of command (show tables, select, etc)
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  georgedj
bq.  
bq.



> ^C breaks out of running query, but not whole CLI
> -------------------------------------------------
>
>                 Key: HIVE-243
>                 URL: https://issues.apache.org/jira/browse/HIVE-243
>             Project: Hive
>          Issue Type: Wish
>          Components: Query Processor
>    Affects Versions: 0.8.0
>            Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. I can do
that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was some control
character to break out of a query without breaking out of the CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message