hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siying Dong" <>
Subject Re: Review Request: CommandNeedRetryException needs release locks and some related code cleaning up
Date Fri, 22 Apr 2011 04:22:16 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated 2011-04-22 04:22:16.136899)

Review request for hive, Yongqiang He and namit jain.


execute() not to throw any exception.


now when CommandNeedRetryException is thrown, locks are not released. Not sure whether it
will cause problem, since the same locks will be acquired when retrying it. It is anyway something
we need to fix. Also we can do some little code cleaning up to make future mistakes less likely.

This addresses bug HIVE-2123.

Diffs (updated)

  trunk/cli/src/java/org/apache/hadoop/hive/cli/ 1095838 
  trunk/hwi/src/java/org/apache/hadoop/hive/hwi/ 1095838 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/ 1095838 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/ 1095838 





  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message