hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Russell Melick" <rmel...@cs.hmc.edu>
Subject Re: Review Request: HIVE-1644 Use filter pushdown for automatically accessing indexes
Date Fri, 22 Apr 2011 03:52:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/558/#review528
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java
<https://reviews.apache.org/r/558/#comment1094>

    When we run a query on a non-partitioned table, we get a single partition in queryPartitions
of the whole table (with an empty partSpec).  Then, when we add the partition columns to the
list of indexed column, we end up adding all the columns in the src table, instead of just
the partitioned ones.  If we make sure the partSpec isn't empty, this doesn't happen.



ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
<https://reviews.apache.org/r/558/#comment1095>

    We need to cast the work in this task to MapredWork in order to get the input size out
(line 176).  I'm not sure if this is the best place to do that checking.



ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
<https://reviews.apache.org/r/558/#comment1096>

    See above comment about MapredWork


- Russell


On 2011-04-22 03:50:54, Russell Melick wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/558/
> -----------------------------------------------------------
> 
> (Updated 2011-04-22 03:50:54)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> Review request for HIVE-1644.12.patch
> 
> 
> This addresses bug HIVE-1644.
>     https://issues.apache.org/jira/browse/HIVE-1644
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2cdaeb6 
>   conf/hive-default.xml 79ea477 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java ca337a8 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 69ee03b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java c02d90b 
>   ql/src/java/org/apache/hadoop/hive/ql/index/AbstractIndexHandler.java dd0186d 
>   ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexHandler.java 411b78f 
>   ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexQueryContext.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java 1f01446

>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 50db44c 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java 6162676 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/IndexWhereResolver.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java 0ae9fa2

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcCtx.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereTaskDispatcher.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 374e123 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c41bb32 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java 73391e9 
>   ql/src/test/queries/clientpositive/index_auto.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/index_auto_file_format.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/index_auto_multiple.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/index_auto_partitioned.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/index_auto_unused.q PRE-CREATION 
>   ql/src/test/results/clientpositive/index_auto.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/index_auto_file_format.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/index_auto_multiple.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/index_auto_partitioned.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/index_auto_unused.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/558/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Russell
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message