hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: Addressing Carl's comments.
Date Thu, 21 Apr 2011 23:49:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/618/#review526
-----------------------------------------------------------



trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/618/#comment1090>

    I think it should be possible to specify multiple metastore listeners. Can you please
make the following changes:
    
    * Change the name of the conf property from "hive.metastore.listener" to "hive.metastore.event.listeners"
and update the description to indicate that this is a comma separated list of listener classnames.
    
    * Change the default value for this property to be an empty string.
    
    * Update the code that initializes these listeners. You can cut and paste the code that's
used to initialize hive.exec.pre.hooks
    


- Carl


On 2011-04-18 18:44:05, Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/618/
> -----------------------------------------------------------
> 
> (Updated 2011-04-18 18:44:05)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Summary
> -------
> 
> Addresses Carl's comment for previous patch. 
> Also added a new method finalizePartition in metastore through which metastore client
can indicate to metastore that partition can be finalized.
> 
> 
> This addresses bug HIVE-2038.
>     https://issues.apache.org/jira/browse/HIVE-2038
> 
> 
> Diffs
> -----
> 
>   trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1094688 
>   trunk/conf/hive-default.xml 1094688 
>   trunk/metastore/if/hive_metastore.thrift 1094688 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1094688 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1094688 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1094688

>   trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
1094688 
>   trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1094688

>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1094688

>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1094688

>   trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1094688 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1094688

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1094688 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1094688

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
PRE-CREATION 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1094688

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1094688

>   trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION

>   trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/618/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message