hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ning Zhang" <nzh...@fb.com>
Subject Re: Review Request: HIVE-2086. Data loss with external table
Date Wed, 20 Apr 2011 18:17:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/604/#review508
-----------------------------------------------------------

Ship it!


- Ning


On 2011-04-15 01:34:56, Jonathan Natkins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/604/
> -----------------------------------------------------------
> 
> (Updated 2011-04-15 01:34:56)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> Review request for HIVE-2086.  The external parameters were being set, but then being
zeroed out by a call to params.clear(), resulting in an external table that wasn't marked
as external.
> 
> 
> This addresses bug HIVE-2086.
>     https://issues.apache.org/jira/browse/HIVE-2086
> 
> 
> Diffs
> -----
> 
>   build-common.xml 9f21a69 
>   data/files/ext_test/test.dat PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9d8919c 
>   ql/src/test/queries/clientpositive/create_like.q 2edde83 
>   ql/src/test/results/clientpositive/create_like.q.out 63a8939 
> 
> Diff: https://reviews.apache.org/r/604/diff
> 
> 
> Testing
> -------
> 
> Automated tests added
> 
> 
> Thanks,
> 
> Jonathan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message