hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ning Zhang" <nzh...@fb.com>
Subject Re: Review Request: HIVE-243 - ^C breaks out of running query, but not whole CLI.
Date Wed, 20 Apr 2011 17:51:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/#review505
-----------------------------------------------------------



trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/626/#comment1030>

    Does this handle the case when a MapReduce job is launched and CLI got a CTL+C? Currently
we have a JVM shutdownHook defined in HadoopJobExecHelper.java to kill the MR job before the
JVM shut down (the old behavior when hitting a CTL+C). 
    
    Here if we don't shut down the JVM, you should do the same thing to kill the running MR
jobs. 


- Ning


On 2011-04-20 16:49:05, georgedj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/626/
> -----------------------------------------------------------
> 
> (Updated 2011-04-20 16:49:05)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> Fixed by adding INT signal hander that interrupts the CLI thread. The CLI thread gets
InterruptedException and it stops the current command.
> 
> 
> This addresses bug HIVE-243.
>     https://issues.apache.org/jira/browse/HIVE-243
> 
> 
> Diffs
> -----
> 
>   trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1095439 
> 
> Diff: https://reviews.apache.org/r/626/diff
> 
> 
> Testing
> -------
> 
> Manual test Ctrl+C on bunch of command (show tables, select, etc)
> 
> 
> Thanks,
> 
> georgedj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message