hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: HIVE-2090: Add "DROP DATABASE ... FORCE"
Date Wed, 13 Apr 2011 00:48:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/551/#review393
-----------------------------------------------------------



trunk/metastore/if/hive_metastore.thrift
<https://reviews.apache.org/r/551/#comment743>

    Does changing the Thrift IDL like this break backwards compatibility with older clients?



trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
<https://reviews.apache.org/r/551/#comment744>

    Missing "@param force..."
    


- Carl


On 2011-04-06 01:01:26, Carl Steinbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/551/
> -----------------------------------------------------------
> 
> (Updated 2011-04-06 01:01:26)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/secure/attachment/12475548/HIVE-2090.3.patch
> 
> 
> This addresses bug HIVE-2090.
>     https://issues.apache.org/jira/browse/HIVE-2090
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/if/hive_metastore.thrift 1088810 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1088810 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1088810 
>   trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1088810

>   trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
1088810 
>   trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1088810

>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1088810

>   trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1088810

>   trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1088810 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1088810

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1088810 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1088810

>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1088810 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1088810 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1088810

>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1088810 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 1088810 
>   trunk/ql/src/test/queries/clientpositive/database.q 1088810 
>   trunk/ql/src/test/results/clientpositive/database.q.out 1088810 
> 
> Diff: https://reviews.apache.org/r/551/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Carl
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message