hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2135) Refactor HiveMetaStore.java
Date Wed, 27 Apr 2011 18:27:03 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025936#comment-13025936
] 

jiraposter@reviews.apache.org commented on HIVE-2135:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/669/
-----------------------------------------------------------

(Updated 2011-04-27 18:24:42.458082)


Review request for hive, Carl Steinbach, John Sichi, and Paul Yang.


Changes
-------

Mistyped jira number.


Summary
-------

See HIVE-2135


This addresses bug HIVE-2135.
    https://issues.apache.org/jira/browse/HIVE-2135


Diffs
-----

  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1096976 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreCommand.java PRE-CREATION

  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1096976 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/URLConnectionUpdater.java PRE-CREATION


Diff: https://reviews.apache.org/r/669/diff


Testing
-------

Since this is a refactoring patch, no new tests are required. Ran all the tests in metastore.
All of them passed.


Thanks,

Ashutosh



> Refactor HiveMetaStore.java
> ---------------------------
>
>                 Key: HIVE-2135
>                 URL: https://issues.apache.org/jira/browse/HIVE-2135
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: refactor.patch
>
>
> HiveMetaStore.java is more then 3000 LOC which contains wide variety of code. It will
be good to refactor it so that its easier to maintain.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message