hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2038) Metastore listener
Date Thu, 21 Apr 2011 22:53:10 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022969#comment-13022969
] 

jiraposter@reviews.apache.org commented on HIVE-2038:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/618/#review522
-----------------------------------------------------------



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/618/#comment1070>

    spacing



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/618/#comment1071>

    formatting



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/618/#comment1072>

    spacing



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/618/#comment1073>

    spacing



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/618/#comment1074>

    spacing



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
<https://reviews.apache.org/r/618/#comment1075>

    This change should go in a separate ticket. What does it mean to "finalize" a partition?



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
<https://reviews.apache.org/r/618/#comment1076>

    spacing



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
<https://reviews.apache.org/r/618/#comment1087>

    Instead of passing in raw Table/Partition/Database objects please wrap these objects in
containers, e.g. CreateTableEvent, DropTableEvent, etc.
    
    Q: Whats the advantage of wrapper container objects?
    
    The advantage of container objects is that it allows us to evolve the API without breaking
compatibility with older clients. With the current interface if I want to add a parameter
to one of these methods I will break compatibility, but if we use container objects I can
add a new field to the container without affecting older clients.



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
<https://reviews.apache.org/r/618/#comment1077>

    spacing



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
<https://reviews.apache.org/r/618/#comment1078>

    spacing



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
<https://reviews.apache.org/r/618/#comment1079>

    spacing



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
<https://reviews.apache.org/r/618/#comment1080>

    Please remove this and include it in a separate patch. We need to discuss what "finalizing"
a partition actually means, and how it relates to locking.



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
<https://reviews.apache.org/r/618/#comment1083>

    spacing



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
<https://reviews.apache.org/r/618/#comment1082>

    spacing



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
<https://reviews.apache.org/r/618/#comment1081>

    spacing



trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
<https://reviews.apache.org/r/618/#comment1086>

    spacing


- Carl


On 2011-04-18 18:44:05, Ashutosh Chauhan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/618/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-04-18 18:44:05)
bq.  
bq.  
bq.  Review request for hive and Carl Steinbach.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Addresses Carl's comment for previous patch. 
bq.  Also added a new method finalizePartition in metastore through which metastore client
can indicate to metastore that partition can be finalized.
bq.  
bq.  
bq.  This addresses bug HIVE-2038.
bq.      https://issues.apache.org/jira/browse/HIVE-2038
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1094688 
bq.    trunk/conf/hive-default.xml 1094688 
bq.    trunk/metastore/if/hive_metastore.thrift 1094688 
bq.    trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1094688 
bq.    trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1094688 
bq.    trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1094688

bq.    trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
1094688 
bq.    trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1094688

bq.    trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1094688

bq.    trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1094688

bq.    trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1094688 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1094688

bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1094688 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1094688

bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
PRE-CREATION 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1094688

bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java PRE-CREATION

bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1094688

bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java PRE-CREATION

bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/618/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ashutosh
bq.  
bq.



> Metastore listener
> ------------------
>
>                 Key: HIVE-2038
>                 URL: https://issues.apache.org/jira/browse/HIVE-2038
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: hive-2038.patch, metastore_listener.patch, metastore_listener.patch,
metastore_listener.patch
>
>
> Provide to way to observe changes happening on Metastore

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message