hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2123) CommandNeedRetryException needs release locks
Date Sat, 23 Apr 2011 02:34:05 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023489#comment-13023489
] 

Carl Steinbach commented on HIVE-2123:
--------------------------------------

@Siying: Thanks for making the change.

+1 on this patch, but I'm -1 on the overall approach of using status return codes instead
of exceptions. Hopefully we can replace the status codes with exceptions during some future
cleanup effort.

> CommandNeedRetryException needs release locks
> ---------------------------------------------
>
>                 Key: HIVE-2123
>                 URL: https://issues.apache.org/jira/browse/HIVE-2123
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Siying Dong
>            Assignee: Siying Dong
>         Attachments: HIVE-2123.1.patch, HIVE-2123.2.patch
>
>
> now when CommandNeedRetryException is thrown, locks are not released. Not sure whether
it will cause problem, since the same locks will be acquired when retrying it. It is anyway
something we need to fix. Also we can do some little code cleaning up to make future mistakes
less likely.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message