hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Hunt (JIRA)" <>
Subject [jira] [Updated] (HIVE-2117) insert overwrite ignoring partition location
Date Thu, 21 Apr 2011 23:59:06 GMT


Patrick Hunt updated HIVE-2117:

    Attachment: HIVE-2117_br07.patch

This patch is a work in progress, it resolves this jira in branch 0.7 while maintaining compatibility
with the requirements from HIVE-1707. All unit tests are passing with this patch applied,
also fixes the example I provided in the description (managed and external table).

I'm still working on two aspects of this JIRA; 1) creating a patch for trunk, and 2) adding
unit tests to verify this behavior.

> insert overwrite ignoring partition location
> --------------------------------------------
>                 Key: HIVE-2117
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Patrick Hunt
>            Priority: Critical
>         Attachments: HIVE-2117_br07.patch, data.txt
> The following code works differently in 0.5.0 vs 0.7.0.
> In 0.5.0 the partition location is respected. 
> However in 0.7.0 while the initial partition is create with the specified location "<path>/parta",
the "insert overwrite ..." results in the partition written to "<path>/dt=a" (note that
<path> is the same in both cases).
> {code}
> create table foo_stg (bar INT, car INT); 
> load data local inpath 'data.txt' into table foo_stg;
> create table foo4 (bar INT, car INT) partitioned by (dt STRING) LOCATION '/user/hive/warehouse/foo4';

> alter table foo4 add partition (dt='a') location '/user/hive/warehouse/foo4/parta';
> from foo_stg fs insert overwrite table foo4 partition (dt='a') select *;
> {code}
> From what I can tell HIVE-1707 introduced this via a change to
> org.apache.hadoop.hive.ql.metadata.Hive.loadPartition(Path, String, Map<String, String>,
boolean, boolean)
> specifically:
> {code}
> +      Path partPath = new Path(tbl.getDataLocation().getPath(),
> +          Warehouse.makePartPath(partSpec));
> +
> +      Path newPartPath = new Path(loadPath.toUri().getScheme(), loadPath
> +          .toUri().getAuthority(), partPath.toUri().getPath());
> {code}
> Reading the description on HIVE-1707 it seems that this may have been done purposefully,
however given the partition location is explicitly specified for the partition in question
it seems like that should be honored (esp give the table location has not changed).
> This difference in behavior is causing a regression in existing production Hive based
code. I'd like to take a stab at addressing this, any suggestions?

This message is automatically generated by JIRA.
For more information on JIRA, see:

View raw message