hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chinna...@huawei.com
Subject Review Request: Few code improvements in the ql and serde packages.
Date Thu, 31 Mar 2011 15:12:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/535/
-----------------------------------------------------------

Review request for hive.


Summary
-------

Few code improvements in the ql and serde packages.
1) Little performance Improvements 
2) Null checks to avoid NPEs
3) Effective varaible management.


This addresses bug HIVE-2080.
    https://issues.apache.org/jira/browse/HIVE-2080


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 1086514 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1086514 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java 1086514 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 1086514 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 1086514 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 1086514 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 1086514 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 1086514 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 1086514 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 1086514 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ASTNode.java 1086514 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1086514 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 1086514 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1086514 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeField.java 1086514

  trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeFieldType.java
1086514 
  trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeFunction.java
1086514 

Diff: https://reviews.apache.org/r/535/diff


Testing
-------

Ran the tests. All tests passed


Thanks,

chinna


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message