hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "namit jain" <nj...@fb.com>
Subject Re: Review Request: HIVE-2050. batch processing partition pruning process
Date Mon, 28 Mar 2011 17:34:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/522/#review355
-----------------------------------------------------------


mostly minor issues - can you update the patch, and I will try to get it in today


trunk/conf/hive-default.xml
<https://reviews.apache.org/r/522/#comment705>

    spelling: alsore



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<https://reviews.apache.org/r/522/#comment706>

    remove commented code



trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
<https://reviews.apache.org/r/522/#comment708>

    Are these parameters used ?



trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
<https://reviews.apache.org/r/522/#comment707>

    This check should be inside the loop where
    we are iterating over all the partitions.
    
    It may not matter, but we are marking all 
    partitions as unknown even if one partition is
    unknown.


- namit


On 2011-03-27 22:59:19, Ning Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/522/
> -----------------------------------------------------------
> 
> (Updated 2011-03-27 22:59:19)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> Introducing a new metastore API to retrieve a list of partitions in batch. 
> 
> 
> Diffs
> -----
> 
>   trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1085555 
>   trunk/conf/hive-default.xml 1085555 
>   trunk/metastore/if/hive_metastore.thrift 1085555 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1085555

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1085555 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1085555

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1085555

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1085555 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1085555 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1085555 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 1085555 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartExprEvalUtils.java 1085555

>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 1085555

> 
> Diff: https://reviews.apache.org/r/522/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ning
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message