hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "M IS" <misapa...@gmail.com>
Subject Re: Review Request: HIVE-2049. Push down partition pruning to JDO filtering for a subset of partition predicates
Date Mon, 14 Mar 2011 03:17:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/489/#review325
-----------------------------------------------------------



trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
<https://reviews.apache.org/r/489/#comment659>

    Here we could have specified the exact size of the ArrayList that is bing created.



trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
<https://reviews.apache.org/r/489/#comment657>

    Here in this case, we really need not catch the HiveException explicitly, as we'll end
up creating one more instance of HiveException as part of the catch block that catches Exception
block



trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
<https://reviews.apache.org/r/489/#comment658>

    It is always preferred that the reference type is generic and not tied to the implementation,
unless it gives access to additional methods. So, changing the type from linkedHashMap to
Map would be preferred.


- M


On 2011-03-11 14:59:46, Ning Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/489/
> -----------------------------------------------------------
> 
> (Updated 2011-03-11 14:59:46)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
>     *  expose HiveMetaStoreClient.listPartitionsByFilter() to Hive.java so that PartitionPruner
can use that for certain partition predicates.
>     * only allows {=, AND, OR} in the partition predicates that can be pushed down to
JDO filtering.
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1080788

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1080788

>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1080788 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1080788 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 1080788

> 
> Diff: https://reviews.apache.org/r/489/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ning
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message