hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Krishna" <n_krishna_ku...@yahoo.com>
Subject Re: Review Request: Patch For Hive 1918 - Export / Import
Date Mon, 28 Feb 2011 17:46:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/430/
-----------------------------------------------------------

(Updated 2011-02-28 09:46:36.900267)


Review request for hive.


Changes
-------

Addressing the two comments re (a) nested ternary ops (b) serialing using auto-gen code


Summary
-------

Patch #4 For Hive 1918


This addresses bug HIVE-1918.
    https://issues.apache.org/jira/browse/HIVE-1918


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a091b95 
  conf/hive-default.xml 4161559 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java f3d6400 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CopyTask.java 6f1df0c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java bedbed6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java e47992a 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 916b235 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 04f560f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 350401d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g dd776bb 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 7551f96 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java f4979f8 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java e7be269 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java 7a62ec7 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java c9282fe 
  ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java d5bccae 
  ql/src/test/org/apache/hadoop/hive/ql/parse/TestEximUtil.java PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_00_unsupported_schema.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_01_nonpart_over_loaded.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_02_all_part_over_overlap.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_03_nonpart_noncompat_colschema.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_04_nonpart_noncompat_colnumber.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_05_nonpart_noncompat_coltype.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_06_nonpart_noncompat_storage.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_07_nonpart_noncompat_ifof.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_08_nonpart_noncompat_serde.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_09_nonpart_noncompat_serdeparam.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_10_nonpart_noncompat_bucketing.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_11_nonpart_noncompat_sorting.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_12_nonnative_export.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_13_nonnative_import.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_14_nonpart_part.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_15_part_nonpart.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_16_part_noncompat_schema.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_17_part_spec_underspec.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_18_part_spec_missing.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_19_external_over_existing.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_20_managed_location_over_existing.q PRE-CREATION

  ql/src/test/queries/clientnegative/exim_21_part_managed_external.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_22_export_authfail.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_23_import_exist_authfail.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_24_import_part_authfail.q PRE-CREATION 
  ql/src/test/queries/clientnegative/exim_25_import_nonexist_authfail.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_00_nonpart_empty.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_01_nonpart.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_02_00_part_empty.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_02_part.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_03_nonpart_over_compat.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_04_all_part.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_04_evolved_parts.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_05_some_part.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_06_one_part.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_07_all_part_over_nonoverlap.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_08_nonpart_rename.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_09_part_spec_nonoverlap.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_10_external_managed.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_11_managed_external.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_12_external_location.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_13_managed_location.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_14_managed_location_over_existing.q PRE-CREATION

  ql/src/test/queries/clientpositive/exim_15_external_part.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_16_part_external.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_17_part_managed.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_18_part_external.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_19_part_external_location.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_20_part_managed_location.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_21_export_authsuccess.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_22_import_exist_authsuccess.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_23_import_part_authsuccess.q PRE-CREATION 
  ql/src/test/queries/clientpositive/exim_24_import_nonexist_authsuccess.q PRE-CREATION 
  ql/src/test/results/clientnegative/exim_00_unsupported_schema.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_01_nonpart_over_loaded.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_02_all_part_over_overlap.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_03_nonpart_noncompat_colschema.q.out PRE-CREATION

  ql/src/test/results/clientnegative/exim_04_nonpart_noncompat_colnumber.q.out PRE-CREATION

  ql/src/test/results/clientnegative/exim_05_nonpart_noncompat_coltype.q.out PRE-CREATION

  ql/src/test/results/clientnegative/exim_06_nonpart_noncompat_storage.q.out PRE-CREATION

  ql/src/test/results/clientnegative/exim_07_nonpart_noncompat_ifof.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_08_nonpart_noncompat_serde.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_09_nonpart_noncompat_serdeparam.q.out PRE-CREATION

  ql/src/test/results/clientnegative/exim_10_nonpart_noncompat_bucketing.q.out PRE-CREATION

  ql/src/test/results/clientnegative/exim_11_nonpart_noncompat_sorting.q.out PRE-CREATION

  ql/src/test/results/clientnegative/exim_12_nonnative_export.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_13_nonnative_import.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_14_nonpart_part.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_15_part_nonpart.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_16_part_noncompat_schema.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_17_part_spec_underspec.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_18_part_spec_missing.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_19_external_over_existing.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_20_managed_location_over_existing.q.out PRE-CREATION

  ql/src/test/results/clientnegative/exim_21_part_managed_external.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_22_export_authfail.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_23_import_exist_authfail.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_24_import_part_authfail.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/exim_25_import_nonexist_authfail.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_00_nonpart_empty.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_01_nonpart.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_02_00_part_empty.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_02_part.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_03_nonpart_over_compat.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_04_all_part.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_04_evolved_parts.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_05_some_part.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_06_one_part.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_07_all_part_over_nonoverlap.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_08_nonpart_rename.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_09_part_spec_nonoverlap.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_10_external_managed.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_11_managed_external.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_12_external_location.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_13_managed_location.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_14_managed_location_over_existing.q.out PRE-CREATION

  ql/src/test/results/clientpositive/exim_15_external_part.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_16_part_external.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_17_part_managed.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_18_part_external.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_19_part_external_location.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_20_part_managed_location.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_21_export_authsuccess.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_22_import_exist_authsuccess.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_23_import_part_authsuccess.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/exim_24_import_nonexist_authsuccess.q.out PRE-CREATION


Diff: https://reviews.apache.org/r/430/diff


Testing
-------

Tests added


Thanks,

Krishna


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message