hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Natkins" <na...@cloudera.com>
Subject Re: Review Request: HIVE-1971. Verbose/echo mode for the Hive CLI.
Date Tue, 08 Feb 2011 22:17:54 GMT


> On 2011-02-08 08:33:08, Ning Zhang wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 194
> > <https://reviews.apache.org/r/404/diff/1/?file=10814#file10814line194>
> >
> >     I don't see why this should be set in HiveConf. IMO, verbose should be pure
client side setting, it should not been passed to the server side.

My intention had been to mimic what I was seeing done with other options, but having it be
client-side only definitely makes sense.  I've removed all the server-side settings.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/404/#review191
-----------------------------------------------------------


On 2011-02-07 23:16:17, Jonathan Natkins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/404/
> -----------------------------------------------------------
> 
> (Updated 2011-02-07 23:16:17)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> This would add a mode to the CLI that echoes any commands that are executed back to the
command line.
> 
> 
> This addresses bug HIVE-1971.
>     https://issues.apache.org/jira/browse/HIVE-1971
> 
> 
> Diffs
> -----
> 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 2b52826 
>   cli/src/java/org/apache/hadoop/hive/cli/OptionsProcessor.java 93a7c95 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a091b95 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 2b0dba8 
> 
> Diff: https://reviews.apache.org/r/404/diff
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Jonathan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message