hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sushanth Sowmyan" <khorg...@gmail.com>
Subject Re: Review Request: Review for HIVE-1818 : jmx instrumentation for HiveMetaStore call frequency and duration
Date Wed, 02 Feb 2011 18:23:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/352/
-----------------------------------------------------------

(Updated 2011-02-02 10:23:23.214832)


Review request for hive.


Changes
-------

Thanks for the review!

I've updated the diff:
- Added open/reopen semantics to MetricsScope, and made Metrics cache the older scopes.
- added requested stack trace
- edited for ){ , }else{ , spaces around operators, spaces between arguments, and 100 char
limit


Summary
-------

HIVE-1818 : jmx instrumentation for HiveMetaStore call frequency and duration


This addresses bug HIVE-1818.
    https://issues.apache.org/jira/browse/HIVE-1818


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1066213 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
1066213 

Diff: https://reviews.apache.org/r/352/diff


Testing
-------


Thanks,

Sushanth


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message