hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "He Yongqiang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1881) Add an option to use FsShell to delete dir in warehouse
Date Wed, 05 Jan 2011 02:26:45 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977591#action_12977591
] 

He Yongqiang commented on HIVE-1881:
------------------------------------

{quote}
I don't understand the motivation for this change, but assuming that
FsShell provides features unavailable in FileSystem, is there any reason
why we can't replace the FileSystem based implementation with the new
one that uses FsShell?
{quote}

Yeah, we can replace it completely. But there is an overhead of using FsShell since it requires
a new process. We just want to go to the new code path only needed. For normal ones, just
keep the old behavior.

{quote}
I think you can simplify the interface by making getSessionConfStore() private,
and then calling it from getConf() and setConf() which can now be made static. Then
you'll be able to call

SessionConfStore.getConf()

instead of

SessionConfStore.getSessionConfStore().getConf()
{quote}


will do it and upload a new patch. 

Thanks!

> Add an option to use FsShell to delete dir in warehouse
> -------------------------------------------------------
>
>                 Key: HIVE-1881
>                 URL: https://issues.apache.org/jira/browse/HIVE-1881
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: He Yongqiang
>            Assignee: He Yongqiang
>         Attachments: HIVE-1881.1.patch
>
>
> >>@Yongqiang: What's the motivation for doing this?
> This is to work with some internal hacky codes about doing delete. There should be no
impact if you use open source hadoop.
> But the idea here is to give users 2 options to do the delete. In Facebook, we have some
customized code in FsShell which can control whether the delete should go through trash or
not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message