hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: HIVE-1929: Find a way to disable owner grants
Date Thu, 27 Jan 2011 00:41:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/359/#review165
-----------------------------------------------------------



trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/359/#comment331>

    These are string valued properties. Please make the default value "" instead of null.



trunk/conf/hive-default.xml
<https://reviews.apache.org/r/359/#comment332>

    This default value should appear in HiveConf.



trunk/conf/hive-default.xml
<https://reviews.apache.org/r/359/#comment333>

    Please add a description explaining what this property does.



trunk/ql/src/java/org/apache/hadoop/hive/ql/session/CreateTableAutomaticGrant.java
<https://reviews.apache.org/r/359/#comment334>

    Please consider returning an empty list (e.g. with Collections.emptyList()) instead of
returning null. Returning null complicates the calling contract and adds to clutter.


- Carl


On 2011-01-26 16:28:54, Carl Steinbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/359/
> -----------------------------------------------------------
> 
> (Updated 2011-01-26 16:28:54)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> Review for HIVE-1929.
> 
> 
> This addresses bug HIVE-1929.
>     https://issues.apache.org/jira/browse/HIVE-1929
> 
> 
> Diffs
> -----
> 
>   trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1063819 
>   trunk/conf/hive-default.xml 1063819 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/session/CreateTableAutomaticGrant.java
1063819 
> 
> Diff: https://reviews.apache.org/r/359/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Carl
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message