hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: HIVE-1910: Provide config parameters to control cache object pinning
Date Wed, 26 Jan 2011 04:44:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/343/#review156
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<https://reviews.apache.org/r/343/#comment320>

    According to javadoc PersistenceManagerFactory.getDataStoreCache() never returns null,
but if it does then we just silently skip this setup. I think we should remove this null check.



http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<https://reviews.apache.org/r/343/#comment321>

    If the user has specified a classname that is not found in the PINCLASSMAP then we just
silently ignore it, which is not a good idea.
    
    Please add some INFO level logging statements a) echo the METASTORE_CACHE_PINOBJTYPES
value and indicate that this is being used to the set the pin list, and b) log a message if
the list contains a name that is not found in the PINCLASSMAP.
    
    I also want to suggest that replace the PINCLASSMAP with a list of the actual classnames,
and require METASTORE_CACHE_PINOBJTYPES to specify the actual classname (e.g. MSerDeInfo,
MTable, etc), instead of a name that you transform and then map to the real name.


- Carl


On 2011-01-24 11:50:46, Mac Yang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/343/
> -----------------------------------------------------------
> 
> (Updated 2011-01-24 11:50:46)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> Review for HIVE-1910
> 
> 
> This addresses bug HIVE-1910.
>     https://issues.apache.org/jira/browse/HIVE-1910
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
1062921 
>   http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1062921 
>   http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
1062921 
> 
> Diff: https://reviews.apache.org/r/343/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mac
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message