Return-Path: Delivered-To: apmail-hive-dev-archive@www.apache.org Received: (qmail 36061 invoked from network); 29 Nov 2010 10:33:11 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 29 Nov 2010 10:33:11 -0000 Received: (qmail 1397 invoked by uid 500); 29 Nov 2010 10:33:11 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 1365 invoked by uid 500); 29 Nov 2010 10:33:11 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 1357 invoked by uid 500); 29 Nov 2010 10:33:11 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 1354 invoked by uid 99); 29 Nov 2010 10:33:11 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Nov 2010 10:33:11 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Nov 2010 10:33:08 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oATAWli3017027 for ; Mon, 29 Nov 2010 10:32:47 GMT Message-ID: <24236051.13701291026767339.JavaMail.jira@thor> Date: Mon, 29 Nov 2010 05:32:47 -0500 (EST) From: "HBase Review Board (JIRA)" To: hive-dev@hadoop.apache.org Subject: [jira] Commented: (HIVE-1526) Hive should depend on a release version of Thrift MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964684#action_12964684 ] HBase Review Board commented on HIVE-1526: ------------------------------------------ Message from: "Carl Steinbach" bq. On 2010-11-22 14:37:20, Ning Zhang wrote: bq. > ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java, line 416 bq. > bq. > bq. > This should not be MAPREDLOCAL, but MAPRED. Since MapRedTask extends ExecDriver which implements getType(), this function should not be here in MapRedTask. Removed. bq. On 2010-11-22 14:37:20, Ning Zhang wrote: bq. > ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java, line 592 bq. > bq. > bq. > It would be better to define a new OperatorType for SMBMapJoinOperator. Done. bq. On 2010-11-22 14:37:20, Ning Zhang wrote: bq. > ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java, line 348 bq. > bq. > bq. > commnet: -1 -> null I made this method abstract. - Carl ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1242/#review1958 ----------------------------------------------------------- > Hive should depend on a release version of Thrift > ------------------------------------------------- > > Key: HIVE-1526 > URL: https://issues.apache.org/jira/browse/HIVE-1526 > Project: Hive > Issue Type: Task > Components: Build Infrastructure, Clients > Reporter: Carl Steinbach > Assignee: Carl Steinbach > Fix For: 0.7.0 > > Attachments: HIVE-1526-complete.4.patch.txt, HIVE-1526-no-codegen.3.patch.txt, HIVE-1526-no-codegen.4.patch.txt, HIVE-1526.2.patch.txt, HIVE-1526.3.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar, serde2_test.patch, svn_rm.sh, thrift-0.5.0.jar, thrift-fb303-0.5.0.jar > > > Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency. > The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.