hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amareshwari Sriramadasu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1750) Remove Partition Filtering Conditions when Possible
Date Tue, 02 Nov 2010 08:50:29 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927334#action_12927334
] 

Amareshwari Sriramadasu commented on HIVE-1750:
-----------------------------------------------

A couple of minor comments:
* javadoc for isOpNot and isOpOr in FunctionRegistry is wrong. Do you want to correct it?
* For the below code change in many optimizers :
{code}
+          prunedParts = pGraphContext.getOpToPartList().get(tso);
+          if (prunedParts == null) {
+            prunedParts = PartitionPruner.prune(....);
+          }
{code}
I was expecting a pGraphContext.getOpToPartList().put().
Is PartitonPruner.prune call really needed in all those places, because PartitionConditionRemover
already does a put if it is not null ? Correct me if I'm wrong.

> Remove Partition Filtering Conditions when Possible
> ---------------------------------------------------
>
>                 Key: HIVE-1750
>                 URL: https://issues.apache.org/jira/browse/HIVE-1750
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Siying Dong
>            Assignee: Siying Dong
>         Attachments: HIVE-1750.1.patch, HIVE-1750.2.patch
>
>
> For some simple queries, partition filtering constraints take 8% of CPU time (now 16%
since we filter twice) even if the result is always true. When possible, we should remove
these constraints to save CPU times.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message