hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1526) Hive should depend on a release version of Thrift
Date Mon, 29 Nov 2010 10:32:47 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964684#action_12964684
] 

HBase Review Board commented on HIVE-1526:
------------------------------------------

Message from: "Carl Steinbach" <carl@cloudera.com>


bq.  On 2010-11-22 14:37:20, Ning Zhang wrote:
bq.  > ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java, line 416
bq.  > <http://review.cloudera.org/r/1242/diff/1/?file=17504#file17504line416>
bq.  >
bq.  >     This should not be MAPREDLOCAL, but MAPRED. Since MapRedTask extends ExecDriver
which implements getType(), this function should not be here in MapRedTask.

Removed.


bq.  On 2010-11-22 14:37:20, Ning Zhang wrote:
bq.  > ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java, line 592
bq.  > <http://review.cloudera.org/r/1242/diff/1/?file=17509#file17509line592>
bq.  >
bq.  >     It would be better to define a new OperatorType for SMBMapJoinOperator.

Done.


bq.  On 2010-11-22 14:37:20, Ning Zhang wrote:
bq.  > ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java, line 348
bq.  > <http://review.cloudera.org/r/1242/diff/1/?file=17514#file17514line348>
bq.  >
bq.  >     commnet: -1 -> null

I made this method abstract.


- Carl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1242/#review1958
-----------------------------------------------------------





> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
>                 Key: HIVE-1526
>                 URL: https://issues.apache.org/jira/browse/HIVE-1526
>             Project: Hive
>          Issue Type: Task
>          Components: Build Infrastructure, Clients
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1526-complete.4.patch.txt, HIVE-1526-no-codegen.3.patch.txt,
HIVE-1526-no-codegen.4.patch.txt, HIVE-1526.2.patch.txt, HIVE-1526.3.patch.txt, hive-1526.txt,
libfb303.jar, libthrift.jar, serde2_test.patch, svn_rm.sh, thrift-0.5.0.jar, thrift-fb303-0.5.0.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve
this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message