hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Liyin Tang (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HIVE-1785) change Pre/Post Query Hooks to take in 1 parameter: HookContext
Date Tue, 16 Nov 2010 19:44:14 GMT

     [ https://issues.apache.org/jira/browse/HIVE-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Liyin Tang updated HIVE-1785:
-----------------------------

    Attachment: hive_1785_2.patch

Thanks for John's comments.

Now in the Driver.java:
for (PostExecute peh : getPostExecHooks()) {
        if (peh instanceof ExecuteWithHookContext) {
          ((ExecuteWithHookContext) peh).run(hookContext);
        } else {
          peh.run(SessionState.get(), plan.getInputs(), plan.getOutputs(),
              (SessionState.get() != null ? SessionState.get().getLineageState().getLineageInfo()
                  : null), ShimLoader.getHadoopShims().getUGIForConf(conf));
        }
   }

Let's discuss about the interface of HookContext. How much information we should keep in the
HookContext.
Right now, I keep the query plan, job conf and completed tasks. 


> change Pre/Post Query Hooks to take in 1 parameter: HookContext
> ---------------------------------------------------------------
>
>                 Key: HIVE-1785
>                 URL: https://issues.apache.org/jira/browse/HIVE-1785
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Liyin Tang
>         Attachments: hive_1785_1.patch, hive_1785_2.patch
>
>
> This way, it would be possible to add new parameters to the hooks without changing the
existing hooks.
> This will be a incompatible change, and all the hooks need to change to the new API

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message