hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Namit Jain (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1738) Optimize Key Comparison in GroupByOperator
Date Thu, 21 Oct 2010 19:00:27 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923568#action_12923568
] 

Namit Jain commented on HIVE-1738:
----------------------------------

 * Also, for string and test elements, it performs slightly better than

spelling: (should be Text)




  public ListObjectsEqualComparer(ObjectInspector[] oi0, ObjectInspector[] oi1) {
    assert(oi0.length == oi1.length);


Instead of asserting, can you throw an error ?




       } else {
         assert(type0.equals(type1));
         compareType = CompareType.SAME_TYPE;


Dont assert same type ?
types can be different - it wont happen for GroupBy


Otherwise, it looks great

> Optimize Key Comparison in GroupByOperator
> ------------------------------------------
>
>                 Key: HIVE-1738
>                 URL: https://issues.apache.org/jira/browse/HIVE-1738
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Siying Dong
>            Assignee: Siying Dong
>         Attachments: HIVE.1738.1.patch, HIVE.1738.2.patch
>
>
> GroupByOperator uses ObjectInspectorUtils.compare() to compare keys, which is written
for generalized object comparisons, which is not optimized for group-by operator. By optimizing
this logic, we expect to see obvious improvements in GroupByOperator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message