hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amareshwari Sriramadasu (JIRA)" <>
Subject [jira] Commented: (HIVE-1534) Join filters do not work correctly with outer joins
Date Wed, 15 Sep 2010 06:04:33 GMT


Amareshwari Sriramadasu commented on HIVE-1534:

bq. Did you run all the tests ? Some of the tests should break - minimally a change of explain
I commented Explain annotation for filter predicates to skip test failures with explain plans
for now; trying to figure out if filter predicates can be displayed only when they are present.
Even then, all the tests did not pass. I'm looking into the failures.

bq. What about semi joins ? 
I did not do anything for semi join. I will go through semi join and its expected output with
filters. Will update the patch if any changes are needed and add tests.

bq. Why did you add a genExprNode() ? Cant you re-use the one from SemanticAnalyzer ?
genExprNode() in SemanticAnalyzer is not a static method. It uses unparseTranslator while
generating. Will change genExprNode() in SemanticAnalyzer to use the new static method introduced
and remove duplicate code.

> Join filters do not work correctly with outer joins
> ---------------------------------------------------
>                 Key: HIVE-1534
>                 URL:
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>         Attachments: patch-1534-1.txt, patch-1534.txt
>  SELECT * FROM T1 LEFT OUTER JOIN T2 ON (T1.c1=T2.c2 AND T1.c1 < 10)
> and  SELECT * FROM T1 RIGHT OUTER JOIN T2 ON (T1.c1=T2.c2 AND T2.c1 < 10)
> do not give correct results.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message