Mailing-List: contact hive-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hive-dev@hadoop.apache.org
Message-ID: <1300117.197151281085576662.JavaMail.jira@thor>
Date: Fri, 6 Aug 2010 05:06:16 -0400 (EDT)
From: "Bennie Schut (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Subject: [jira] Commented: (HIVE-1482) Not all jdbc calls are threadsafe.
In-Reply-To: <6273492.536181279874451854.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895997#action_12895997 ] 

Bennie Schut commented on HIVE-1482:
------------------------------------

Ok I think I covered the sync stuff like you sugested.
For the state part I was looking at how SessionState is used within the HiveConnection.
There are several spots where we pass a sessionstate object (HivePreparedStatement, HiveStatement) but both places end up not actually using the object. Simplest thing would be not to pass them. But even if we do pass it I think it only contains session data and not query specific data.
Query specific things like column names/types etc. can be done nicely within a sync block together with the client call for the query itself so that shouldn't be a problem.

I'll upload a patch with what I have soon.

> Not all jdbc calls are threadsafe.
> ----------------------------------
>
>                 Key: HIVE-1482
>                 URL: https://issues.apache.org/jira/browse/HIVE-1482
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Drivers
>    Affects Versions: 0.7.0
>            Reporter: Bennie Schut
>             Fix For: 0.7.0
>
>
> As per jdbc spec they should be threadsafe:
> http://download.oracle.com/docs/cd/E17476_01/javase/1.3/docs/guide/jdbc/spec/jdbc-spec.frame9.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.