hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <>
Subject [jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar
Date Mon, 23 Aug 2010 23:02:17 GMT


HBase Review Board commented on HIVE-1546:

Message from: "John Sichi" <>

This is an automatically generated e-mail. To reply, visit:

    Can you break this out into several statements for readability?

    This does not belong in HiveUtils.  Can't we just leave it where it is (in SemanticAnalyzerFactory)
and add a public accessor method for it so that extensions can reuse it?

    Why does this return a String []?  The callers don't use it.

    Putting "Interface" into the interface name is clunky.
    Let's call the interface HiveSemanticAnalyzerFactory instead (matching the convention
for other plugin interfaces such as HiveStorageHandler and HiveIndexHandler).
    In addition, I think we should introduce a new interface HiveSemanticAnalyzer and have
the factory produce that, since factories should generally produce interfaces rather than
classes (e.g. so that dynamic proxies can be used).

    This configuration parameter needs to be defined in following the pattern
already in use there.
    Also, it needs a new entry in conf/hive-default.xml

    Our convention for existing Hive plugins is to make them extend org.apache.hadoop.conf.Configurable
and pass in the configuration only once via setConf (rather than to individual methods such
as get).
    Inside a Configurable, you can get back to a HiveConf with:
    new HiveConf(getConf(), YourClass.class)

- John

> Ability to plug custom Semantic Analyzers for Hive Grammar
> ----------------------------------------------------------
>                 Key: HIVE-1546
>                 URL:
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 0.7.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.7.0
>         Attachments: hive-1546.patch
> It will be useful if Semantic Analysis phase is made pluggable such that other projects
can do custom analysis of hive queries before doing metastore operations on them. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message