Return-Path: Delivered-To: apmail-hadoop-hive-dev-archive@minotaur.apache.org Received: (qmail 36360 invoked from network); 26 Jul 2010 22:22:59 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 26 Jul 2010 22:22:59 -0000 Received: (qmail 886 invoked by uid 500); 26 Jul 2010 22:22:59 -0000 Delivered-To: apmail-hadoop-hive-dev-archive@hadoop.apache.org Received: (qmail 799 invoked by uid 500); 26 Jul 2010 22:22:59 -0000 Mailing-List: contact hive-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hive-dev@hadoop.apache.org Delivered-To: mailing list hive-dev@hadoop.apache.org Received: (qmail 790 invoked by uid 99); 26 Jul 2010 22:22:59 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jul 2010 22:22:59 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [75.101.130.251] (HELO ip-10-250-127-239.ec2.internal) (75.101.130.251) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jul 2010 22:22:52 +0000 Received: from ip-10-250-127-239.ec2.internal (localhost.localdomain [127.0.0.1]) by ip-10-250-127-239.ec2.internal (Postfix) with ESMTP id 9CAB91056C; Mon, 26 Jul 2010 22:22:31 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HIVE-1126, patch 6 From: "Carl Steinbach" To: jiraposter@review.hbase.org, hive-dev@hadoop.apache.org, "John Sichi" , "Carl Steinbach" Date: Mon, 26 Jul 2010 22:22:31 -0000 Message-ID: <20100726222231.4823.64968@ip-10-250-127-239.ec2.internal> In-Reply-To: <20100726220653.21036.53470@ip-10-250-127-239.ec2.internal> References: <20100726220653.21036.53470@ip-10-250-127-239.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/385/#review486 ----------------------------------------------------------- Ship it! +1 Looks good to me. - Carl On 2010-07-26 15:06:53, John Sichi wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/385/ > ----------------------------------------------------------- > = > (Updated 2010-07-26 15:06:53) > = > = > Review request for Hive Developers. > = > = > Summary > ------- > = > Review for HIVE-1126 patch 6 by jvs. > = > = > This addresses bug HIVE-1126. > http://issues.apache.org/jira/browse/HIVE-1126 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apa= che/hadoop/hive/jdbc/HiveBaseResultSet.java PRE-CREATION = > http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apa= che/hadoop/hive/jdbc/HiveCallableStatement.java 978817 = > http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apa= che/hadoop/hive/jdbc/HiveConnection.java 978817 = > http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apa= che/hadoop/hive/jdbc/HiveDatabaseMetaData.java 978817 = > http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apa= che/hadoop/hive/jdbc/HiveMetaDataResultSet.java PRE-CREATION = > http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apa= che/hadoop/hive/jdbc/HivePreparedStatement.java 978817 = > http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apa= che/hadoop/hive/jdbc/HiveQueryResultSet.java PRE-CREATION = > http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apa= che/hadoop/hive/jdbc/HiveResultSet.java 978817 = > http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apa= che/hadoop/hive/jdbc/HiveResultSetMetaData.java 978817 = > http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apa= che/hadoop/hive/jdbc/HiveStatement.java 978817 = > http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apa= che/hadoop/hive/jdbc/JdbcColumn.java PRE-CREATION = > http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apa= che/hadoop/hive/jdbc/JdbcTable.java PRE-CREATION = > http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/test/org/apa= che/hadoop/hive/jdbc/TestJdbcDriver.java 978817 = > = > Diff: http://review.hbase.org/r/385/diff > = > = > Testing > ------- > = > = > Thanks, > = > John > = >