hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "He Yongqiang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HIVE-1348) Moving inputFileChanged() from ExecMapper to where it is needed
Date Wed, 02 Jun 2010 16:34:37 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874646#action_12874646
] 

He Yongqiang commented on HIVE-1348:
------------------------------------

Ning, thanks for updating!

Overall looks good to me. Some minor comments:

1. in MapjoinOperator
if (tag == posBigTable && this.getExecContext().getLastInputFile() == null) {

we may need to remove "this.getExecContext().getLastInputFile() == null" because of bucket
mapjoin

2. i did no see where we set the var "inputFileChecked" in ExecMapperContext to true.  


> Moving inputFileChanged() from ExecMapper to where it is needed
> ---------------------------------------------------------------
>
>                 Key: HIVE-1348
>                 URL: https://issues.apache.org/jira/browse/HIVE-1348
>             Project: Hadoop Hive
>          Issue Type: Improvement
>            Reporter: Ning Zhang
>            Assignee: He Yongqiang
>         Attachments: hive-1348.1.patch, hive-1348.2.patch, hive-1348.3.patch, HIVE-1348.4.patch
>
>
> inputFileChanged() is only needed for Bucketed sort merge map join. It should not be
put in ExecMapper.map() where all code paths will hit this function. This function is quite
expensive since JobConf look up is a hash table look up. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message