hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach (JIRA)" <>
Subject [jira] Commented: (HIVE-1123) Checkstyle fixes
Date Thu, 04 Feb 2010 02:42:28 GMT


Carl Steinbach commented on HIVE-1123:

Things that I did automatically using the Eclipse formatter:
Line length:
  Limit is 100

  Spaces between operator and operands except i++
  Spaces between if and (, for and (, while and (
  No spaces between ( and the first operand, or the last operand and )
  Same for {}
Curly braces:
  Required even for single-line if
  } else {

  "Type[] var" instead of "Type var[]"

  Ordered alphabetically

Things I did mainly by hand:
Javadoc Comments:
  Required for all public members (classes, methods) but not getter/setter.
  The first line of each javadoc is the short description. Should end with "."
  Each line of javadoc should start with capital letters.

Keyword order:
  public static final
  Declare the class as final if not intended to be inherited.

   Default private constructor for Utility classes.

  Constant should be all capitalized
  Classes should be first-letter capitalized
  Variable names should be first-letter lowercased, with the first letter of each additional
word capitalized.
  Don't use _ in variable names.

bq. If it's automatic, shall we do it one rule by one rule instead of one package by one package?

A good idea, but many of the changes I made were not automatic, and starting over would require
me to throw away this work. I don't think I have the patience to redo it, at least not right

What are the sticking points preventing you from committing the current version of the patch?
besides the switch brace issue?

> Checkstyle fixes
> ----------------
>                 Key: HIVE-1123
>                 URL:
>             Project: Hadoop Hive
>          Issue Type: Task
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>         Attachments: HIVE-1123.checkstyle.patch, HIVE-1123.cli.2.patch, HIVE-1123.cli.patch,
HIVE-1123.common.2.patch, HIVE-1123.common.patch, HIVE-1123.contrib.2.patch, HIVE-1123.contrib.patch,
HIVE-1123.hwi.2.patch, HIVE-1123.hwi.patch, HIVE-1123.jdbc.2.patch, HIVE-1123.jdbc.patch,
HIVE-1123.metastore.2.patch, HIVE-1123.metastore.patch, HIVE-1123.ql.2.patch, HIVE-1123.ql.patch,
HIVE-1123.serde.2.patch, HIVE-1123.serde.patch, HIVE-1123.service.2.patch, HIVE-1123.service.patch,
HIVE-1123.shims.2.patch, HIVE-1123.shims.patch
> Fix checkstyle errors.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message