Return-Path: Delivered-To: apmail-hadoop-hive-dev-archive@minotaur.apache.org Received: (qmail 72807 invoked from network); 10 Dec 2009 20:20:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 10 Dec 2009 20:20:41 -0000 Received: (qmail 95498 invoked by uid 500); 10 Dec 2009 20:20:41 -0000 Delivered-To: apmail-hadoop-hive-dev-archive@hadoop.apache.org Received: (qmail 95477 invoked by uid 500); 10 Dec 2009 20:20:41 -0000 Mailing-List: contact hive-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hive-dev@hadoop.apache.org Delivered-To: mailing list hive-dev@hadoop.apache.org Received: (qmail 95467 invoked by uid 99); 10 Dec 2009 20:20:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Dec 2009 20:20:41 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Dec 2009 20:20:40 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 3A378234C1EF for ; Thu, 10 Dec 2009 12:20:18 -0800 (PST) Message-ID: <1687845751.1260476418237.JavaMail.jira@brutus> Date: Thu, 10 Dec 2009 20:20:18 +0000 (UTC) From: "Zheng Shao (JIRA)" To: hive-dev@hadoop.apache.org Subject: [jira] Commented: (HIVE-924) Extract LogicalPlan and PhysicalPlan classes from SemanticAnalysis class In-Reply-To: <937091589.1257898588044.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HIVE-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788892#action_12788892 ] Zheng Shao commented on HIVE-924: --------------------------------- Carl, some notes about our meeting today: Currently we have: 1. ParseContext: compile-time thing only 2. Operators: contains the desc, the DAG, and the transient variables for execution-time only. 3. desc: the description of the operator I am in favor of an organization like this: 1. CompileTimeOperator: contains information in ParseContext, and desc + DAG. 2. desc + DAG: these are the information that needs to be propagated from compile time to execution time. We should put them together and give it a new name. 3. Operators: for execution time only, constructed from the desc + DAG. In this way, only desc+DAG is shared between the compile time and execution time and the code can look much cleaner. Does this look good? > Extract LogicalPlan and PhysicalPlan classes from SemanticAnalysis class > ------------------------------------------------------------------------ > > Key: HIVE-924 > URL: https://issues.apache.org/jira/browse/HIVE-924 > Project: Hadoop Hive > Issue Type: Bug > Components: Query Processor > Reporter: Carl Steinbach > Attachments: HIVE-924.patch > > > Currently the SemanticAnalyzer class handles semantic analysis, as well as logical plan generation and physical plan generation. I think it would be beneficial to extract distinct LogicalPlan and PhysicalPlan classes from the SemanticAnalyzer, and have the query processing phase be coordinated by a QueryCompiler class that would be responsible for triggering the parsing, semantic analysis, logical plan generation, optimization, and physical plan generation phases. This proposed reorganization of components would help to isolate the state of each phase, and would also bring the source into closer alignment with the description of the query compiler in the Hive design document on the wiki. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.