Return-Path: 
 <hive-dev-return-8537-apmail-hadoop-hive-dev-archive=hadoop.apache.org@hadoop.apache.org>
Delivered-To: apmail-hadoop-hive-dev-archive@minotaur.apache.org
Received: (qmail 86335 invoked from network); 11 Dec 2009 17:15:41 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 11 Dec 2009 17:15:41 -0000
Received: (qmail 91612 invoked by uid 500); 11 Dec 2009 17:15:41 -0000
Delivered-To: apmail-hadoop-hive-dev-archive@hadoop.apache.org
Received: (qmail 91568 invoked by uid 500); 11 Dec 2009 17:15:40 -0000
Mailing-List: contact hive-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hive-dev-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hive-dev-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hive-dev@hadoop.apache.org>
List-Id: <hive-dev.hadoop.apache.org>
Reply-To: hive-dev@hadoop.apache.org
Delivered-To: mailing list hive-dev@hadoop.apache.org
Received: (qmail 91543 invoked by uid 99); 11 Dec 2009 17:15:40 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Dec 2009 17:15:40 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Dec 2009 17:15:39 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 3055A234C1EF
	for <hive-dev@hadoop.apache.org>; Fri, 11 Dec 2009 09:15:18 -0800 (PST)
Message-ID: <1532313153.1260551718196.JavaMail.jira@brutus>
Date: Fri, 11 Dec 2009 17:15:18 +0000 (UTC)
From: "Edward Capriolo (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Subject: [jira] Commented: (HIVE-978) Hive jars should follow Hadoop naming
 and include version
In-Reply-To: <2018969134.1260486378281.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HIVE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789397#action_12789397 ] 

Edward Capriolo commented on HIVE-978:
--------------------------------------

Chad,

You are going to have to take into acount the shell scripts in bin, and bin/ext/


{noformat}
# needed for execution
if [ ! -f "${HIVE_LIB}/hive_exec.jar" ]; then
  echo "Missing Hive Execution Jar: ${HIVE_LIB}/hive_exec.jar"
  exit 1;
fi

if [ ! -f "${HIVE_LIB}/hive_metastore.jar" ]; then
  echo "Missing Hive MetaStore Jar"
  exit 2;
fi

# cli specific code
if [ ! -f "${HIVE_LIB}/hive_cli.jar" ]; then
  echo "Missing Hive CLI Jar"
  exit 3;
fi

for f in ${HIVE_LIB}/*.jar; do
  CLASSPATH=${CLASSPATH}:$f;
done
{noformat}

There are no unit tests for this, but they reference file names directly.

Also in the hive-default.conf

{noformat}
<property>
  <name>hive.hwi.war.file</name>
  <value>lib/hive_hwi.war</value>
  <description>path appended to HIVE_HOME to locate the HWI WAR file</description>
</property>

{noformat}

> Hive jars should follow Hadoop naming and include version
> ---------------------------------------------------------
>
>                 Key: HIVE-978
>                 URL: https://issues.apache.org/jira/browse/HIVE-978
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Build Infrastructure
>    Affects Versions: 0.5.0
>            Reporter: Chad Metcalf
>            Priority: Minor
>             Fix For: 0.5.0
>
>         Attachments: HIVE-978v1.patch
>
>
> This is a simple patch on the ant build files to change jar naming from
> hive_foo.jar to hive-foo-VERSION.jar
> This matches the convention followed by hadoop jars. This naming scheme is important for packaging, repositories, etc.
> Testing done:
> ant test
> ant tar
> Things look right.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.